Student: ibkaplan Assignment: 2 Grader: Charlie ************************************************ Bresenham: program runs, buggy (55): 55 correct implementation of Bresenham (20): 15 no floats and divides (20): 10 extra credit (5): 2 ---------------------------------------------- total (100): 82 Cohen-Sutherland: program runs, buggy (55): 55 inside case correct (10): 10 outside case correct (10): 10 one clip correct (10): 10 two clips correct (10): 10 extra credit (5): 0 ---------------------------------------------- total (100): 95 Comments: ---------------------------------------------- Bresenham: Your implementation is more complicate than necessary. See the H&B book for a more compact implementation of Bresenham for one octant. Extending that to cover 8 octants is not much more complicated. Also, you did not have to use any divides at all to complete this assignment. Cohen-Sutherland: It was smart to use a loop to save duplicating code to handle both endpoints, but you still did extra work in the clip() procedure because you did not use the knowledge that you only need to call clip() twice. So the second time clip() is run, the first endpoint should be completely clipped, and you would only have to deal with the second endpoint. Why did you use BitSet as oppose to just do bitwise and and bitwise or? By using BitSet, your implementation of isTrivial() and clip() is a lot more complicated than necessary. *************************************************